Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed incorrectly mocked endpoint #18661

Merged
merged 2 commits into from
May 19, 2023
Merged

fixed incorrectly mocked endpoint #18661

merged 2 commits into from
May 19, 2023

Conversation

br41nslug
Copy link
Member

Fixes 2 small issue with the migrated SDK tests

  • an incorrectly updated mock throwing a warning
  • fixed incorrect replacement of the fail function in try-catches

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023

🦋 Changeset detected

Latest commit: 3957a95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@directus/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@rijkvanzanten rijkvanzanten merged commit 85c664f into main May 19, 2023
6 checks passed
@rijkvanzanten rijkvanzanten deleted the sdk-fix-tests branch May 19, 2023 17:08
@rijkvanzanten rijkvanzanten added this to the Next Release milestone May 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants