Fix permissions using dynamic user or role fields #19073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic variables were not fetched, so not being parsed and checked
🦋 Changeset detectedLatest commit: bad1f08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rijkvanzanten
requested review from
paescuj,
a team,
rijkvanzanten and
br41nslug
and removed request for
a team
|
Have tried fixing the unit tests, but have been unable to mock the pinia store successfully. |
|
Should I just remove the unit tests so it will pass, even though I think it is best to include them? |
I'll look into this later that day 👍 |
paescuj
approved these changes
Jul 11, 2023
|
Nice, well done @paescuj thanks! Hopefully we can get this released asap? Have been waiting on a fix for almost a month now. |
rijkvanzanten
approved these changes
Jul 24, 2023
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
* Fix permissions using dynamic user or role fields Dynamic variables were not fetched, so not being parsed and checked * Added tests * Pretty * Tried fixing unit tests. * Finish parse-filter test * Finish parse-preset test * Update permissions store test * Update docs for dynamic filters * Add changeset * Update tiny-carpets-remain.md --------- Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch> Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic variables were not fetched, so not being parsed and checked
Fixes #19039, fixes #18898, fixes #19043