Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatted Kanban card text including HTML tags #19112

Merged
merged 12 commits into from
Jul 12, 2023

Conversation

magnus-bb
Copy link
Contributor

@magnus-bb magnus-bb commented Jul 10, 2023

Fixes HTML tags rendering in Kanban card text of WYSIWYG fields described in #19065.

When setting a formatted display value for WYSIWYG fields...:
image
... the value should now be prettier on the Kanban card:
image

However, the HTML is not rendered on the card. The <render-display> component simply displays the raw values without any HTML tags.

Fixes #19065

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023

🦋 Changeset detected

Latest commit: ada10ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@magnus-bb magnus-bb marked this pull request as ready for review July 10, 2023 13:54
@paescuj paescuj requested review from paescuj, a team, br41nslug and jaads and removed request for paescuj and a team July 11, 2023 08:29
@paescuj paescuj self-assigned this Jul 11, 2023
@paescuj paescuj self-requested a review July 11, 2023 08:30
@paescuj paescuj changed the title fix #19065 formatted Kanban card text includes HTML tags Fix formatted Kanban card text including HTML tags Jul 11, 2023
Copy link
Member

@rijkvanzanten rijkvanzanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! 🚀

@paescuj paescuj enabled auto-merge (squash) July 12, 2023 10:03
@paescuj paescuj merged commit fdee208 into directus:main Jul 12, 2023
6 checks passed
@github-actions github-actions bot added this to the Next Release milestone Jul 12, 2023
sethkaufee pushed a commit to sethkaufee/directus that referenced this pull request Jul 24, 2023
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kanban layout cards only show raw values in the 'Card Text' field
3 participants