Supabase - Storage driver #19135
Supabase - Storage driver #19135
Conversation
…ctus into storage-driver-supabase
🦋 Changeset detectedLatest commit: 7c3314c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matt-rolley
changed the title
paescuj
requested review from
a team,
paescuj,
br41nslug and
azrikahar
and removed request for
a team
|
@matt-rolley Hello, how to run your version to test? Because it is not known if and when she will enter the main directus quest. And I really need it. |
|
Sorry, I've been away for a week so just catching up properly - appreciate the updates and apologies if I've stepped on any toes, I just thought it'd be an interesting feature to add. Hoping to contribute more in the future so please let me know if there is a better way for me to help out :) |
Oh no not at all! Really appreciate this PR and the functionalities it unlocks 😄 My comment earlier was just to explain to @pixelkoduje why running an open source project can't just "just merge it already" yolo mode all the time 😬 I'm aiming to have it reviewed by this weeks release though!
Thanks! PRs are welcome for any Issue (which includes Supabase storage support!) 🙂 Happy to chat on Discord if you want to talk through specifics. |
|
@matt-rolley I'm curious to hear your thoughts on resumable uploads in this context. Where does |
To be honest I'm not 100% sure how it works, I just saw that Supabase supported resumable uploads so I added it into the storage layer. I think resumable uploads would be a great feature, especially for the larger files, but if it'd only be supported on the Supabase storage layer then I agree that it makes more sense to add it to the driver abstraction layer. Does it make sense to remove it from this version until it's better tested/added to the driver abstraction layer? |
Yeah lets do that 👍🏻 Resumable uploads is really something that should be implemented in the Directus API first, and then we can pass that information on to the Supabase (or any other!) driver. I don't think it'll really do anything in it's current state, as Directus will cancel the upload on unexpected errors (rather than retry) |
|
Yeah, agreed - sounds like a plan. I've removed it from the codebase now :) |
There was a problem hiding this comment.
This is looking and feeling great @matt-rolley! 🚀
Really appreciate how closely you've matched the existing code styles and paradigms used. If I didn't know any better, I could've thought this was written by myself 😄
|
This is super exciting - thanks so much guys! |
|
You're welcome :) That's great, really glad it's working nicely! Looking forward to the release, if any issues pop up, feel free to tag me in them :) happy to help where I can. Thanks again for the help in getting this live. |
* Initial commit to add supabase as a storage driver * Working supabase implementation * Slight cleanup * Started working on tests for storage-driver-supabase * Updates * Initial commit to add supabase as a storage driver * Working supabase implementation * Slight cleanup * Started working on tests for storage-driver-supabase * Updates * Nicer working tests * More working tests * Readable stream * Working version with all passing tests and types * Update contributors.yml * added documentation * Ran prettier to fix formatting issues * Ran linter and added Supabase to dictionary * Fix tsconfig reference * Organize imports * Start at v0 * Add changeset * Lock versions * storage-driver-supabse: Added fullpath for move and copy arguments * storage-driver-supabase: Removed resumable uploads * Update lockfile --------- Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
Hey,
I've attempted to add a Supabase storage driver based on the S3 storage driver (where possible). It should help close #16903.
Please let me know if anything needs changing or if I've missed a step (it's my first proper pull request :)) - happy to make any changes that are needed.
Thanks,
Matt