API: Do count distinct since left join duplicates results
#19208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fbaf31e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paescuj
reviewed
Jul 20, 2023
|
LGTM so far, but would be great to have this covered in a test. |
licitdev
approved these changes
Jul 24, 2023
paescuj
approved these changes
Jul 24, 2023
sethkaufee
pushed a commit
to sethkaufee/directus
that referenced
this pull request
Jul 24, 2023
…#19208) * Do count distinct since `left join` duplicates results * Add changeset * Correctly access count property * Update .changeset/angry-suits-compete.md * Optimize for simple filters * Add tests * Workaround broken 'as' for countDistinct in SQLite3 --------- Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch> Co-authored-by: ian <licitdev@gmail.com>
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
…#19208) * Do count distinct since `left join` duplicates results * Add changeset * Correctly access count property * Update .changeset/angry-suits-compete.md * Optimize for simple filters * Add tests * Workaround broken 'as' for countDistinct in SQLite3 --------- Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch> Co-authored-by: ian <licitdev@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some scenarios,
filter_countreturns the result of the amount of relationships instead of just the amount records on current collection.This happens because the results are duplicated since a
left joinis being used.Solution
In order to solve this, we can just do a
countDistinctusing the primary key of the current collection.That will remove the duplicated results and
filter_countwill have proper valueFixes #18608