Remove res.status calculation as it is set later

[u12206050]

res.status is anyways set in either flow later in this function, so no need to loop through errors just for this.

Only edge case is when there are no errors, which would anyways just mean 500 as you can see.

[changeset-bot]

🦋 Changeset detected

Latest commit: ecb425e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@directus/api	Patch
directus	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[u12206050]

Actually, it is better to say that status is overridden later in the flow, so this removed logic, is actually just useless.

[rijkvanzanten]

There's no guarantee that errors[0].status is 500, so this will break the http error status code in case an error is thrown with a non-500 error code (like ForbiddenException) right?

[u12206050]

There's no guarantee that errors[0].status is 500, so this will break the http error status code in case an error is thrown with a non-500 error code (like ForbiddenException) right?

No, but then errors.length is at least 1 so then the logic that follows will execute which if it isn't a DirectusError will set the status accordingly.

[rijkvanzanten]

Ahh right right, I wasn't looking further than the diff that github presented ^^

[rijkvanzanten]

The original intended behavior was to use the err.status as the status code if it existed, or fall back to 500 if multiple errors of different types are thrown or if a non-directus error is thrown. That wasn't working as intended before either, but lets make that work as part of this PR. Small tweak incoming!