Fix Cloudinary root option and file deletion
#19238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd deletes (#19231) * fix(storage-driver-cloudinary): Add file extension in list response Append file extension from Cloudinary query response for image and video assets on "list" calls. * fix(storage-driver-cloudinary): Replace upload folder parameters Replace "folder" param with "asset_folder" and "use_asset_folder_as_public_id_prefix" in uploads * fix(storage-driver-cloudinary): Fix asset folder params and non media uploads Only pass "asset_folder" in upload if there is a "root" path configured. For non image and video assets, parse the base path for the public id. * chore(contributors): added contributor added self to contributors.yml
🦋 Changeset detectedLatest commit: 5f30f5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
* [WIP] Cloudinary root * Attempt to fix `list` * Fix storage root and filename formatting to sync Cloudinary uploads and deletes (directus#19231) * fix(storage-driver-cloudinary): Add file extension in list response Append file extension from Cloudinary query response for image and video assets on "list" calls. * fix(storage-driver-cloudinary): Replace upload folder parameters Replace "folder" param with "asset_folder" and "use_asset_folder_as_public_id_prefix" in uploads * fix(storage-driver-cloudinary): Fix asset folder params and non media uploads Only pass "asset_folder" in upload if there is a "root" path configured. For non image and video assets, parse the base path for the public id. * chore(contributors): added contributor added self to contributors.yml * Add changeset * Remove stray console.log * Fix tests * Rename creds to credentials --------- Co-authored-by: Seth Kaufman <seth.s.kaufman@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18146, fixes #19219. Big thanks to @sethkaufee for helping out! 🚀