Filter out any non existent fields #19352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitwel
requested review from
paescuj,
licitdev and
azrikahar
and removed request for
a team
🦋 Changeset detectedLatest commit: 3c50021 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Could we use that check for other layouts as well? |
|
Checked all other layouts too, but they handle it fine. |
paescuj
approved these changes
Aug 10, 2023
paescuj
requested review from
DanielBiegler
and removed request for
licitdev and
azrikahar
DanielBiegler
approved these changes
Aug 10, 2023
sethkaufee
pushed a commit
to sethkaufee/directus
that referenced
this pull request
Sep 20, 2023
* filter out any non existent fields * hide upsi * fix layout throwing error * Format file * Add changeset --------- Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
* filter out any non existent fields * hide upsi * fix layout throwing error * Format file * Add changeset --------- Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18912
Problem was that we didn't check if a field was non existent anymore causing the layout to crash. Now it gets ignored and fixes itself when you update the tabs again.