Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file preview to m2o-fields if the relation is directus_files #19374

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

DanielBiegler
Copy link
Contributor

fixes #19366

@DanielBiegler DanielBiegler requested a review from a team August 8, 2023 12:51
@DanielBiegler DanielBiegler self-assigned this Aug 8, 2023
@DanielBiegler DanielBiegler requested review from paescuj, jaads and azrikahar and removed request for a team August 8, 2023 12:52
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

🦋 Changeset detected

Latest commit: ea6b64e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now 😄👍

@rijkvanzanten rijkvanzanten enabled auto-merge (squash) August 8, 2023 18:33
@rijkvanzanten rijkvanzanten merged commit a885c7b into main Aug 8, 2023
6 checks passed
@rijkvanzanten rijkvanzanten deleted the fix-19366-show-file-preview-for-m2o-fields branch August 8, 2023 18:36
@github-actions github-actions bot added this to the Next Release milestone Aug 8, 2023
sethkaufee pushed a commit to sethkaufee/directus that referenced this pull request Sep 20, 2023
…ectus#19374)

* add file preview to m2o-fields if the relation is directus_files

* add changeset

* move check to useFile instead of relatedCollection
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
…ectus#19374)

* add file preview to m2o-fields if the relation is directus_files

* add changeset

* move check to useFile instead of relatedCollection
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File preview is missing on edit clickout for file, image, m2o and o2m interfaces
3 participants