Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing check for sort field #19412

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Fix missing check for sort field #19412

merged 3 commits into from
Aug 14, 2023

Conversation

Nitwel
Copy link
Member

@Nitwel Nitwel commented Aug 11, 2023

fixes #18899

@Nitwel Nitwel requested a review from a team August 11, 2023 15:45
@Nitwel Nitwel self-assigned this Aug 11, 2023
@Nitwel Nitwel requested review from rijkvanzanten, br41nslug and DanielBiegler and removed request for a team August 11, 2023 15:45
@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

🦋 Changeset detected

Latest commit: f12ae56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@DanielBiegler DanielBiegler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me now, nice!

@paescuj paescuj enabled auto-merge (squash) August 14, 2023 09:24
@paescuj paescuj merged commit 8b91e7c into main Aug 14, 2023
6 checks passed
@paescuj paescuj deleted the fix-18899 branch August 14, 2023 09:32
@github-actions github-actions bot added this to the Next Release milestone Aug 14, 2023
sethkaufee pushed a commit to sethkaufee/directus that referenced this pull request Sep 20, 2023
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kanban layout regrouping fails when sort field is not set
3 participants