Fix deep sanitizeQuery #19436
Merged
Fix deep sanitizeQuery #19436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0ee31cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paescuj
requested review from
a team,
rijkvanzanten,
DanielBiegler and
jaads
and removed request for
a team
|
Added a test case which proves that it didn't work correctly before this fix: |
jaads
approved these changes
Aug 24, 2023
sethkaufee
pushed a commit
to sethkaufee/directus
that referenced
this pull request
Sep 20, 2023
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19435
So instead of sanitising each part of a subquery by itself, this refactor groups the fields starting with
_into a query to be sanitised together and then afterwards all of it is added back to the parsedQuery without the randomness of just taking the first element in the entries array.