Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Fixed relational object merging #19482

Merged
merged 3 commits into from
Aug 21, 2023
Merged

SDK Fixed relational object merging #19482

merged 3 commits into from
Aug 21, 2023

Conversation

br41nslug
Copy link
Member

Fixes #19338

This PR attempts to fix a type inference issue in relational fields.

Before:
image
image

After:
image

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023

🦋 Changeset detected

Latest commit: 83149f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@directus/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@br41nslug br41nslug requested review from a team, paescuj, rijkvanzanten and azrikahar and removed request for a team August 21, 2023 09:23
Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 🚀

@rijkvanzanten rijkvanzanten merged commit e4f92c7 into main Aug 21, 2023
6 checks passed
@rijkvanzanten rijkvanzanten deleted the sdk-19338 branch August 21, 2023 13:46
@github-actions github-actions bot added this to the Next Release milestone Aug 21, 2023
sethkaufee pushed a commit to sethkaufee/directus that referenced this pull request Sep 20, 2023
* Fix relational object merging

* Create thick-ducks-learn.md
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
* Fix relational object merging

* Create thick-ducks-learn.md
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relation type problems with readItems
3 participants