Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout previews in presets view #19528

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Fix layout previews in presets view #19528

merged 3 commits into from
Aug 29, 2023

Conversation

paescuj
Copy link
Member

@paescuj paescuj commented Aug 25, 2023

Fix various issues with layout previews in presets view:

Cards

Before
After

Calendar

Before
After

Map

Before
After

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2023

🦋 Changeset detected

Latest commit: 0897a09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@directus/app Patch
@directus/composables Patch
@directus/types Patch
@directus/api Patch
@directus/extensions-sdk Patch
directus Patch
create-directus-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paescuj paescuj requested review from a team, rijkvanzanten, DanielBiegler and azrikahar and removed request for a team August 25, 2023 12:41
@jaads jaads self-requested a review August 29, 2023 10:07
@paescuj paescuj removed the request for review from DanielBiegler August 29, 2023 10:07
Copy link
Member

@jaads jaads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

@azrikahar azrikahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolves said issue as described in the PR! (also fixes a quirk with table layout "hiding" the first row of items that I noticed during the review)

@azrikahar azrikahar merged commit 302a7a1 into main Aug 29, 2023
7 checks passed
@azrikahar azrikahar deleted the fix-preset-layout-preview branch August 29, 2023 15:28
@github-actions github-actions bot added this to the Next Release milestone Aug 29, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
* Fix layout previews in presets view

* Add changeset

---------

Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants