Improving SDK error/response handling #19539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4564527 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
br41nslug
requested review from
a team,
paescuj,
rijkvanzanten and
jaads
and removed request for
a team
|
@br41nslug Should we consider this a breaking change? |
|
Hmm, the error output could definitely be a breaking change for those relying on the error structure as it was 🤔 |
paescuj
reviewed
Aug 28, 2023
paescuj
reviewed
Aug 29, 2023
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
* improving error/response handling * updated request function to expose the response on error * updated the composables where needed * Create few-rules-talk.md * ran prettier * undid unintended type change * added missing awaits for onResponse * Update few-rules-talk.md * Mark it as major change * unpack directus errors instead of nesting * ran prettier * Update .changeset/few-rules-talk.md Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch> --------- Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19304
Added the response object in the thrown error for any request if the error is one returned from Directus.
Added the original request object to the
onResponse(result, request)handler