Fix JSON values in raw editors and input-code #19608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ceef964 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
azrikahar
requested review from
a team,
paescuj,
br41nslug and
jaads
and removed request for
a team
br41nslug
reviewed
Sep 7, 2023
br41nslug
approved these changes
Sep 7, 2023
paescuj
reviewed
Sep 7, 2023
app/src/interfaces/_system/system-raw-editor/system-raw-editor.vue
Outdated
Show resolved
Hide resolved
paescuj
approved these changes
Sep 8, 2023
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently input-code interface has the following logic to stringify JSON when the type is json or the value is object:
directus/app/src/interfaces/input-code/input-code.vue
Lines 105 to 107 in 26fb314
However it is not accounting for a specific combination of
type is jsonandtypeof value is string, which is why string value such as{{my_operation}}is being "doubly escape quoted". Fixes #19469The similar fix was then applied to system-raw-editor (the one used in Flows and Insights) and form-field-raw-editor. Fixes #19244
Also added a drive-by one-liner fix in form-field-raw-editor line 98 to prevent
JSON.parsefrom breaking when trying to parse values such as{{my_operation}}.