Attempt to make "require shares fields" migration safer/more reliable #19619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4d37132 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paescuj
requested review from
a team,
rijkvanzanten,
DanielBiegler and
jaads
and removed request for
a team
paescuj
changed the title
paescuj
commented
Sep 7, 2023
azrikahar
reviewed
Sep 11, 2023
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
azrikahar
approved these changes
Sep 11, 2023
br41nslug
approved these changes
Sep 12, 2023
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
…directus#19619) Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the last correction of the "require shares fields" migration in #19407, it seems that there are still MySQL instances that struggle with this migration (see #19399).
Unfortunately this could not be reproduced so far, so here's an attempt to make the migration a bit safer/more reliable:
ALTER TABLEstatements, because depending on the engine it may not be supported to drop & recreate in the same statement.Closes #19399 (we'll reopen if issue should still not be solved)