Allow update-check to work in read-only envs & add timeout
#19636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 58137f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paescuj
requested review from
a team,
rijkvanzanten,
br41nslug and
DanielBiegler
and removed request for
a team
paescuj
force-pushed
the
read-only-timeout-update-check
branch
from
eca2fb7
to
09f6d03
Compare
rijkvanzanten
approved these changes
Sep 9, 2023
The cache dir usually doesn't exist, so we need to create it first. If the dir shouldn't exist already, this also catches the case when fs is read only - if it should exist but fs is read only, the cache is now forgivable enough to not fail. 'fs.access' would not be sufficiently reliable anyway, since permission could change between the check and write action.
br41nslug
reviewed
Sep 11, 2023
br41nslug
approved these changes
Sep 11, 2023
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
…s#19636) * Allow update-check to work in read-only envs & add timeout * Update deps in 'update-check' * Add changeset * Switch to `got` * Fix dir check The cache dir usually doesn't exist, so we need to create it first. If the dir shouldn't exist already, this also catches the case when fs is read only - if it should exist but fs is read only, the cache is now forgivable enough to not fail. 'fs.access' would not be sufficiently reliable anyway, since permission could change between the check and write action. * Add basic test * Disable retry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19578
Switching to the request library
gotfor the following reasons:node-fetch-cacheTested in Docker (with
--read-only&--network none) ✅