Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Improved input checks #19702

Merged
merged 8 commits into from
Sep 16, 2023
Merged

SDK Improved input checks #19702

merged 8 commits into from
Sep 16, 2023

Conversation

br41nslug
Copy link
Member

Fixes #19621

Added a lot of type guards against empty strings and abstracted the core collection check

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023

🦋 Changeset detected

Latest commit: 8431d9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@directus/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@br41nslug br41nslug requested review from a team, paescuj, rijkvanzanten and DanielBiegler and removed request for a team September 15, 2023 13:41
Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and an insider for @br41nslug

Copy link
Member

@rijkvanzanten rijkvanzanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please unflip all desks ┬─┬ノ(ಠ_ಠノ)

@rijkvanzanten rijkvanzanten merged commit 366b867 into main Sep 16, 2023
6 checks passed
@rijkvanzanten rijkvanzanten deleted the sdk-19621 branch September 16, 2023 15:51
@github-actions github-actions bot added this to the Next Release milestone Sep 16, 2023
joselcvarela pushed a commit that referenced this pull request Sep 18, 2023
* added extra guards for a couple commands

* Abstracted guard checking to util

* Updated the delete commands

* Updated the read commands

* Updated the update commands

* Create slow-buckets-draw.md

* my friend prettier
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
* added extra guards for a couple commands

* Abstracted guard checking to util

* Updated the delete commands

* Updated the read commands

* Updated the update commands

* Create slow-buckets-draw.md

* my friend prettier
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK - readItem not returning null/error when ID is empty
3 participants