-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add display options for repeater #19703
Conversation
🦋 Changeset detectedLatest commit: f8e2122 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points, instead of using a divider, I think using a group to hide the display options might help with the clutteredness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to also have the docs updated in this PR, right? 🤔 |
would it be possible to group interface and interface options together as well? 🤔 |
is "raw value" missing under "display label"? I would have expect it there since it's also an option when changing the display type after the field got created |
It is the default display anyways to just unselecting any display is the same as selecting the raw display. |
Oh, didn't knew we had docs on this. Will update them! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I have created a repeater (field/column is calledsomething
) with two fields called first
and second
. the interface works fine. I can add data to those two fields. I created one item, this it how it looks in in the database: [{"first":"one","second":"two"}]
.
I did not specify any display. I would expect the studio to show me the raw data like above but is doesn't. instead it shows me the value of the first field, which is one
here.
If you don't specify any display template, by default it will fallback to the first field I'm pretty sure. So that is as to be expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, @Nitwel! Works & looks great! ❤️
Co-authored-by: Brainslug <tim@brainslug.nl> Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch> Co-authored-by: Jan Arends <jan.arends@mailbox.org>
closes #19692
Adds options for specifying a display on the repeater interface.