Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle packages #19712

Merged
merged 20 commits into from
Sep 26, 2023
Merged

Bundle packages #19712

merged 20 commits into from
Sep 26, 2023

Conversation

paescuj
Copy link
Member

@paescuj paescuj commented Sep 16, 2023

Enable straightforward bundling of the following packages:

  • @directus/composables
  • @directus/constants
  • @directus/pressure
  • @directus/schema
  • @directus/storage-driver-azure
  • @directus/storage-driver-cloudinary
  • @directus/storage-driver-gcs
  • @directus/storage-driver-local
  • @directus/storage-driver-s3
  • @directus/storage-driver-supabase
  • @directus/storage
  • @directus/update-check

Also align tsconfig.json files:

  • Remove outDir which is no longer necessary
  • Ensure include is defined to prevent warnings like

    Cannot write file 'packages/data-sql/dist/index.d.ts' because it would overwrite input file

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2023

🦋 Changeset detected

Latest commit: e609f4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@directus/composables Patch
@directus/constants Patch
@directus/data-driver-postgres Patch
@directus/data-sql Patch
@directus/data Patch
@directus/pressure Patch
@directus/random Patch
@directus/schema Major
@directus/storage-driver-azure Patch
@directus/storage-driver-cloudinary Patch
@directus/storage-driver-gcs Patch
@directus/storage-driver-local Patch
@directus/storage-driver-s3 Patch
@directus/storage-driver-supabase Patch
@directus/storage Patch
@directus/extensions-sdk Patch
@directus/api Patch
create-directus-extension Patch
@directus/types Patch
@directus/utils Patch
@directus/validation Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paescuj paescuj added 🍰 Optimization Codebase / repo optimization Package: @directus/data labels Sep 16, 2023
@paescuj paescuj requested review from a team, rijkvanzanten, jaads and azrikahar and removed request for a team September 16, 2023 20:31
Copy link
Member

@jaads jaads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. bundles as expected 🎉

br41nslug

This comment was marked as resolved.

@paescuj

This comment was marked as resolved.

Copy link
Contributor

@azrikahar azrikahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The built bundle runs without any noticeable issues on my end 👍

@azrikahar azrikahar merged commit c67775a into main Sep 26, 2023
7 checks passed
@azrikahar azrikahar deleted the bundle-packages-v2 branch September 26, 2023 13:14
@github-actions github-actions bot added this to the Next Release milestone Sep 26, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
* Bundle `@directus/composables`

* Bundle `@directus/constants`

* Align tsconfig in `data` packages

To prevent warnings like
> Cannot write file 'packages/data-sql/dist/index.d.ts' because it would overwrite input file

* Bundle `@directus/pressure`

* Align tsconfig in `@directus/random`

* Bundle `@directus/schema`

* Bundle `@directus/storage`

* Bundle `@directus/storage-driver-azure`

* Bundle `@directus/storage-driver-cloudinary`

* Bundle `@directus/storage-driver-gcs`

* Bundle `@directus/storage-driver-local`

* Bundle `@directus/storage-driver-s3`

* Align tsconfig in `@directus/themes`

* Bundle `@directus/update-check`

* Add changeset

* Bundle `storage-driver-supabase`

* Update changeset

* Remove dedicated export of 'types/overview'
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🍰 Optimization Codebase / repo optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants