Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle @directus/utils #19714

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Bundle @directus/utils #19714

merged 3 commits into from
Sep 20, 2023

Conversation

paescuj
Copy link
Member

@paescuj paescuj commented Sep 16, 2023

Enable bundling of the package

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2023 •
edited

🦋 Changeset detected

Latest commit: d13e791

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@directus/utils Patch
@directus/api Patch
@directus/composables Patch
@directus/extensions-sdk Patch
@directus/pressure Patch
@directus/storage-driver-azure Patch
@directus/storage-driver-cloudinary Patch
@directus/storage-driver-gcs Patch
@directus/storage-driver-local Patch
@directus/storage-driver-s3 Patch
@directus/storage-driver-supabase Patch
@directus/validation Patch
directus Patch
create-directus-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paescuj paescuj requested review from a team, rijkvanzanten, br41nslug and DanielBiegler and removed request for a team September 16, 2023 21:15
@paescuj paescuj requested a review from jaads September 17, 2023 07:46
br41nslug
br41nslug reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@br41nslug br41nslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine but after the change to node18 tsconfig iot for some reason targets node16 🤔 should this not be node18?
image

@paescuj
Copy link
Member Author

paescuj commented Sep 18, 2023

Seems to work fine but after the change to node18 tsconfig iot for some reason targets node16 🤔 should this not be node18? image

Oh thanks, good catch!

Apparently, tsup isn't able to locate the tsconfig files, therefore using individual commands now where the paths to the files are specified manually.

jaads
jaads approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@jaads jaads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to work as expected now. the target is the same as the one specified in the tsconfig and the three modules build successfully.

@paescuj paescuj merged commit 1fd9259 into main Sep 20, 2023
7 checks passed
@paescuj paescuj deleted the bundle-utils branch September 20, 2023 20:38
@github-actions github-actions bot added this to the Next Release milestone Sep 20, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
@paescuj @br-rafaelbarros
Bundle @directus/utils (directus#19714)
4a01f59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@br41nslug br41nslug br41nslug approved these changes

@jaads jaads jaads approved these changes

@rijkvanzanten rijkvanzanten Awaiting requested review from rijkvanzanten rijkvanzanten was automatically assigned from directus/review

@DanielBiegler DanielBiegler Awaiting requested review from DanielBiegler DanielBiegler was automatically assigned from directus/review

Assignees
No one assigned
Labels
🍰 Optimization
Projects
None yet
Milestone
v10.6.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paescuj @br41nslug @jaads