-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace csv-parser with papaparse #19739
Conversation
🦋 Changeset detectedLatest commit: ff7c6fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the PR! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, semicolons work now! Tested the following basic example:
"bool";"msg";"name"
true;"enabled first yea";"first"
null;"null second hello";"second"
false;"disabled third yeasssss";"third"
But skipped values are now interpreted as an empty string: ""
which fails for other datatypes. In my boolean example from above if you skip the null
(which is how our export does it) the import fails.
On v10.6.2
without papaparser
left out values work, as they're null
.
So the following works on v10.6.2
but not with this PR:
"bool","msg","name"
true,"enabled first yea","first"
,"null second hello","second"
false,"disabled third yeasssss","third"
Here is the error message you'll see:
[INTERNAL_SERVER_ERROR] insert into "titles" ("bool", "msg", "name") values ($1, $2, $3) returning "id" - invalid input syntax for type boolean: ""
With the latest changes it behaves the same as before with @DanielBiegler Can you check out again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did multiple tests with multiple different configs and formats and relations and everything worked! ❤️ LGTM 🚀 🚀 🚀
Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com> Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Replaces csv-parser with papaparse.
This allows for supporting better detection of separators such as
;
Value parsing also seems to be easier with papaparse.
Fixes #15874