Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket subscription filtering #19743

Merged
merged 16 commits into from
Oct 11, 2023
Merged

Fix websocket subscription filtering #19743

merged 16 commits into from
Oct 11, 2023

Conversation

br41nslug
Copy link
Member

@br41nslug br41nslug commented Sep 20, 2023

Fixes #19704

What changed

  • merged the getSinglePayload and getMultiPayload functions for better consistency in the returned payloads with filter and item

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023

🦋 Changeset detected

Latest commit: 3767fee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@br41nslug br41nslug marked this pull request as ready for review October 9, 2023 09:16
@br41nslug
Copy link
Member Author

br41nslug commented Oct 9, 2023

Setting this back to draft so it doesnt get merged with blackbox errors.

@br41nslug br41nslug marked this pull request as draft October 9, 2023 13:55
@br41nslug br41nslug marked this pull request as ready for review October 10, 2023 11:24
@br41nslug br41nslug requested review from a team and paescuj and removed request for a team October 10, 2023 11:24
Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 🥇

@paescuj paescuj merged commit a982dfc into main Oct 11, 2023
7 checks passed
@paescuj paescuj deleted the fix-19704 branch October 11, 2023 12:56
@github-actions github-actions bot added this to the Next Patch Release milestone Oct 11, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
Co-authored-by: ian <licitdev@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Realtime subscription 'filter/item' property not working properly
4 participants