Set payload filename on upload even if primaryKey exists. #19771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way on image replace we update the file extension on disk and download filename.
🦋 Changeset detectedLatest commit: 693ac0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
DanielBiegler
requested review from
a team,
paescuj,
br41nslug and
DanielBiegler
and removed request for
a team
DanielBiegler
approved these changes
Sep 25, 2023
br41nslug
approved these changes
Sep 25, 2023
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
…9771) * Set payload filename on upload even if primaryKey exists. This way on image replace we update the file extension on disk and download filename. * Add 0x2aff to contributors.yml * Put 0x2aff contributor into quotes. * add changeset * Update changeset to reflect also extension --------- Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #19657
The multipart handler on file upload only sets the payload filename if we upload new file.
If we always add the filename to the payload we always update the file extension on disk and download-filename.