Add missing null-check for user-role in user-popover-component. #19774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just added the null-check. If the user has no active role this means that the popover will only show the active status without role. Maybe it would be better to show here the information that the user does not have a role assigned?
🦋 Changeset detectedLatest commit: a023dbd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0x2aff
force-pushed
the
fix/19773_AvatarDisplayNotFound
branch
from
dd63dc6
to
fcc8d43
Compare
DanielBiegler
requested review from
a team,
rijkvanzanten,
jaads and
azrikahar
and removed request for
a team
paescuj
reviewed
Sep 23, 2023
paescuj
approved these changes
Sep 23, 2023
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
…ctus#19774) Co-authored-by: Daniel Biegler <DanielBiegler@users.noreply.github.com> Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #19773
The user-popover component is missing a null-check for the Directus user role. Hovering over the display of a user without a role will lead to the rendering problem described in the issue.
Just added the null-check. If the user has no active role this means that the popover will only show the active status without role.
Maybe it would be better to add the information that the user has no active role?
With role:
Without role:
