Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Fixes serverPing output type #19789

Merged
merged 2 commits into from
Sep 25, 2023
Merged

SDK Fixes serverPing output type #19789

merged 2 commits into from
Sep 25, 2023

Conversation

br41nslug
Copy link
Member

Fixes #19775

An extends object sneaked in on the Output type of client.request resulting in object being the minimum fallback while the output may be anything from void to string to json payload.

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: bb53724

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@directus/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@paescuj paescuj merged commit f4fdc28 into main Sep 25, 2023
6 checks passed
@paescuj paescuj deleted the fix-19775 branch September 25, 2023 10:53
@github-actions github-actions bot added this to the Next Release milestone Sep 25, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type for return of client.request(serverPing())
2 participants