Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Fixes websocket subscription output typing #19791

Merged
merged 4 commits into from
Sep 25, 2023
Merged

SDK Fixes websocket subscription output typing #19791

merged 4 commits into from
Sep 25, 2023

Conversation

br41nslug
Copy link
Member

@br41nslug br41nslug commented Sep 25, 2023

Fixes #19538

Fixes output types for websocket subscriptions in the SDK.
This adds both the missing init and error message payloads to the output typing.

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: f62541d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@directus/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@br41nslug br41nslug requested review from a team, paescuj, rijkvanzanten and DanielBiegler and removed request for a team September 25, 2023 10:52
Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ❤️

@paescuj paescuj merged commit b33fbe2 into main Sep 25, 2023
6 checks passed
@paescuj paescuj deleted the fix-19538 branch September 25, 2023 11:24
@github-actions github-actions bot added this to the Next Release milestone Sep 25, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect types on websocket subscriptions
2 participants