-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix format of stored field conditions value #19799
Conversation
🦋 Changeset detectedLatest commit: 3e424a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe my findings are out of scope for this PR but wanted to still share for a future issue maybe:
My fields had conditions before this PR, so this happened for me on first opening:
But after you open the new dialog and close it, it disappears. (reappears when closing+reopening the side drawer)
and it also bugs out the first time you add a new condition but subsequent conditions work it's a lil' finicky, see the following video 😄
Screencast.from.25.09.2023.18.09.04.webm
Yeah, this is to be expected, unfortunately, if you added conditions under v10.6.2. You could manually "fix" the format in such a case via "Raw Editor". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm this fixes basic conditions
firefox_TQKKRHeioK.mp4
We will need to mention somewhere, i suppose in the release notes, that any conditions created or edited since the 10.6.2 release last week will need to be adjusted/fixed/recreated.
I was thinking if we could catch/fix these incorrectly saved conditions with a migration or similar but i suspect that would cause more issues than it'd solve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested multiple scenarios and all the basic ones and nested fields inside groups worked for me also. Sadly the expansion of groups still doesnt work see #19571 but thats a different issue - Awesome fix nice one! ❤️
Exactly, I would rather avoid that in favor of a simple note in the release notes. |
A note on the breaking changes page in the docs then perhaps? |
* Fix format of stored field conditions value * Add changeset
Fixes #19757
Regression introduced with #19639:
v-form
requires the conditions value to be passed in form of{ conditions }
.But instead of retrieving it that way in the getter, it was incorrectly stored in this form.
The form of the stored value shouldn't be changed as otherwise the conditions have no effect.
Review Guide