Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redaction of objects with circular structure #19834

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Conversation

paescuj
Copy link
Member

@paescuj paescuj commented Sep 27, 2023

Fixes #19833

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: 866b794

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paescuj paescuj marked this pull request as draft September 27, 2023 23:51
@paescuj paescuj marked this pull request as ready for review September 28, 2023 07:59
Copy link
Member

@licitdev licitdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix with WeakSet! 👍
Added some thoughts below, non-blocking~

api/src/utils/redact-object.ts Show resolved Hide resolved
api/src/utils/redact-object.ts Outdated Show resolved Hide resolved
@paescuj paescuj merged commit 45f8eeb into main Sep 28, 2023
7 checks passed
@paescuj paescuj deleted the fix-redact-circular branch September 28, 2023 15:32
@github-actions github-actions bot added this to the Next Release milestone Sep 28, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authenticate scope in Flow causes error
3 participants