Use comments for embed insertion #19860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7417642 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rijkvanzanten
added
Package: @directus/api
🍰 Optimization
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
* Use comments for embed insertion * Add changeset
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dev-mode, the elements aren't replaced as SERVE_APP is false. That'd cause the whole app to be wrapped in a non-existing custom element:
Which was due to the fact that we used
<embed-head />as the token to replace. By switching to a comment, we can prevent that type of weirdness if the embedding fails or isn't available in dev mode. Also switched the replacement from a regex to a string, as it's a known unique comment we're replacing.