-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bye-bye, Jest #19886
The head ref may contain hidden characters: "blackbox-\u{1F680}"
Bye-bye, Jest #19886
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This reverts commit da807c6.
This reverts commit d6fbdd7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactoring generally LGTM. There's too much to realistically go over everything in full detail, but seeing we didn't alter the tests contents and the test still pass, this should be good to go 馃憤馃徎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Hello Vitest! 馃憢 @paescuj Thank you for the PR~ 馃挴
On a side note, there are some TS errors in tests but those could be fixed in a separate PR. 馃殌
* Bye-bye, Jest * Clean-up non-null assertions for PORT * Test all vendors * Consistent file names * Try with MSSQL 2022 * Revert "Try with MSSQL 2022" This reverts commit da807c6. * Try to run on Windows for better MSSQL perf * Worth a try (hopefully runs MSSQL faster this way) * Start docker services via bash * Quick attempt with local installation of MSSQL * Test with MSSQL 2019 * Back to ubuntu-latest for other tests * Add typecheck cmd * Revert "Test all vendors" This reverts commit d6fbdd7. * Use TS for Vitest config file * Simplify vendors typecasting --------- Co-authored-by: ian <licitdev@gmail.com>
So Long, and Thanks for All the Fish
Scope
What's changed:
@directus/utils
(wasn't possible due to ESM)tsconfig.json
, others already there)Potential Risks / Drawbacks
Review Questions
(see new
pnpm typecheck
command)Successful test run: https://github.com/directus/directus/actions/runs/6405405868