Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add folder prop to v-upload so that import can use it #19897

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

DanielBiegler
Copy link
Contributor

Scope

What's changed:

  • Passed folder prop to v-upload so upload functions can use it for placing images into the correct folder

Potential Risks / Drawbacks

  • The preset prop was used in the useUpload() function and folder overwrites it like so:
if (props.folder) {
	folderPreset.folder = props.folder;
}

which then affects the upload function but that should be fine

Review Questions

  • I don't see further implications that this could have, do you?

Fixes #19891

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

🦋 Changeset detected

Latest commit: 2045066

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DanielBiegler DanielBiegler requested review from a team, paescuj, br41nslug and azrikahar and removed request for a team October 4, 2023 10:26
@paescuj paescuj merged commit 44a70db into main Oct 4, 2023
6 checks passed
@paescuj paescuj deleted the fix-19891-import-via-url-into-current-folder branch October 4, 2023 11:46
@github-actions github-actions bot added this to the Next Release milestone Oct 4, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading Image from URL inside a folder doesn't save the folder path location
2 participants