Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Fix aggregation on multiple fields #19965

Merged
merged 5 commits into from
Oct 10, 2023
Merged

SDK Fix aggregation on multiple fields #19965

merged 5 commits into from
Oct 10, 2023

Conversation

br41nslug
Copy link
Member

@br41nslug br41nslug commented Oct 9, 2023

Fixes #19939

Scope

What's changed:

  • Updated the aggregate() input and output typing
  • Updated docs with an example showing that aggregation on multiple fields is

Potential Risks / Drawbacks

  • None i'm aware of

Review Questions

  • I would like to lorem ipsum

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023

🦋 Changeset detected

Latest commit: d2fb46e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
docs Patch
@directus/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@br41nslug br41nslug marked this pull request as ready for review October 10, 2023 16:19
@br41nslug br41nslug requested review from a team, jaads and paescuj and removed request for a team October 10, 2023 16:21
@paescuj
Copy link
Member

paescuj commented Oct 10, 2023

Screenshot 2023-10-10 at 18 21 30

Me too, my friend. Me too. 😃

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@paescuj paescuj merged commit 250b7bb into main Oct 10, 2023
7 checks passed
@paescuj paescuj deleted the fix-19939 branch October 10, 2023 21:55
@github-actions github-actions bot added this to the Next Patch Release milestone Oct 10, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregate on multiple fields in SDK
2 participants