Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render global rules under globals rule in theme overrides interface #20280

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

rijkvanzanten
Copy link
Member

@rijkvanzanten rijkvanzanten commented Oct 31, 2023

Scope

What's changed:

  • Updated the system-theme-overrides interface to show global rules in globals collapsable section

Potential Risks / Drawbacks

n/a

Review Notes / Questions

  • This is one of the rare cases we explicitly don't use translations. All technical keys are based on the JSON schema, the globals key should match that style.
  • The way this works is by adding a fake $root group, and omitting the level from the path if the $root key is encountered

Fixes #20279

Copy link

changeset-bot bot commented Oct 31, 2023

🦋 Changeset detected

Latest commit: dbb6e8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Minor
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rijkvanzanten rijkvanzanten self-assigned this Oct 31, 2023
@rijkvanzanten rijkvanzanten merged commit ff4f7fd into main Oct 31, 2023
5 checks passed
@rijkvanzanten rijkvanzanten deleted the issue/20279 branch October 31, 2023 19:42
@github-actions github-actions bot added this to the Next Patch Release milestone Oct 31, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put all rules that have no children in a "globals" group
1 participant