-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Email Templates to new White Label Style #20390
Conversation
🦋 Changeset detectedLatest commit: 320e8c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ❤️
- I've tested the template across Gmail, Thunderbird, Outlook, and Apple Mail and it looks good throughout, with the exception of Gmail on mobile in dark mode where we get the following issue with the png logo being reversed out in color. This issue does not exist with the Cloud email template as the entire square is a png, whereas here just the rabbit is a png and the square is a styled img. The reason it has to be this way is so that the logo can be easily replaced inside that same shape and the color behind the rabbit/logo changed based on the
projectColor
.
I think this is an acceptable trade-off, the logo is still visible to some extend. Others seem to struggle with this problem too 1 and I'm not really sure if there's a good solution so far.
Footnotes
Thank you @AlexGaillard ❣️❣️❣️ |
Scope
What's changed:
./api/src/services/mail/templates
have been replaced with new html and css to update them to the same look used on Directus Cloud.projectColor
passed to the liquid parser has been changed from#546e7a
to#171717
to match the Cloud email brandingbase.liquid
that renders the linkManage Your Account
which has been changed to instead render a link to theprojectUrl
prop rather than the 'url' prop.Potential Risks / Drawbacks
projectColor
.Review Notes / Questions
Fixes #20389