Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming various #20426

Merged
merged 52 commits into from
Nov 16, 2023
Merged

Theming various #20426

merged 52 commits into from
Nov 16, 2023

Conversation

rijkvanzanten
Copy link
Member

@rijkvanzanten rijkvanzanten commented Nov 14, 2023

Scope

What's changed:

  • Updated the included minimal / color-match themes
  • Remove merge conflict leftover files
  • Made sure themes are manually ordered
  • Fix module bar styling glitches
  • Add ability to "sync with project" in user theme selector
  • Add support for setting font weights
  • Add scope for configuring popover menus
  • Make for input height and spacing configurable
  • Add support for setting display font weight in header bar

Potential Risks / Drawbacks

  • Visual glitches

Review Notes / Questions

n/a

Copy link

changeset-bot bot commented Nov 14, 2023

🦋 Changeset detected

Latest commit: 7cf64e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@directus/extensions Minor
@directus/themes Minor
docs Minor
@directus/api Minor
@directus/app Minor
create-directus-extension Patch
@directus/extensions-sdk Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paescuj
Copy link
Member

paescuj commented Nov 14, 2023

  • Sidebar seems to be in inactive state (too bright) in Color Match theme.

    Screenshot
  • Notice no longer has a background color in Color Match theme.
    Might be confusing since the interface itself still has a background color (compare with the input field above in screenshot).

    Screenshot
  • Similar thing with the radio interface, although that might be intentional (just here for confirmation 😇).

    Screenshot
  • Theme interface shows colors from current appearance only.

    Screencast
  • Should we add a short description for themes below the title? The name "Color Match" in particular seems a little cryptic to me.

    Screenshot
  • Missing docs for new theme extension type.

  • Would love it if the "Theme" section could become somewhat more compact. Especially in the user settings as an admin you have to scroll quite a bit until you reach the "Admin Options". For example, the Customization interfaces could be hidden behind an "Advanced" button.

    Screencast

@rijkvanzanten rijkvanzanten marked this pull request as ready for review November 16, 2023 18:38
@rijkvanzanten rijkvanzanten merged commit 8d8b649 into main Nov 16, 2023
5 checks passed
@rijkvanzanten rijkvanzanten deleted the theming-various branch November 16, 2023 20:36
@github-actions github-actions bot added this to the Next Release milestone Nov 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants