Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to hostname for OAS URL if no PUBLIC_URL specified #20460

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Conversation

paescuj
Copy link
Member

@paescuj paescuj commented Nov 17, 2023

Allows the OAS to be usable in Swagger Editor ("Try it out" button) when no PUBLIC_URL has been specified which is usually the case in dev env.

Copy link

changeset-bot bot commented Nov 17, 2023

🦋 Changeset detected

Latest commit: 1e8bc39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@br41nslug br41nslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fallback 🚀

@br41nslug br41nslug merged commit 6953ad4 into main Nov 17, 2023
4 checks passed
@br41nslug br41nslug deleted the oas-url branch November 17, 2023 15:49
@github-actions github-actions bot added this to the Next Release milestone Nov 17, 2023
@paescuj paescuj mentioned this pull request Nov 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants