Fix BigInt primary key routing

[wasimTQ]

Scope

What's changed:

• Fixes the routing error when opening a bigint value

Potential Risks / Drawbacks

Review Notes / Questions

• I'd like to know whether it fixes the error and are there any other aspects get affected by this change

---

Fixes #20288

[changeset-bot]

🦋 Changeset detected

Latest commit: f116552

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@directus/api	Patch
directus	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[wasimTQ]

@br41nslug Can you review it?

[paescuj]

Thanks @wasimTQ!

The fix looks sensible 👍 (Although, I'm not able to reproduce the issue #20288 in particular).
We need to add a new test case for this before we can merge.

[br41nslug]

Using the native BigInt type solves the issue nicely on my end :D

[paescuj]

Can confirm as well 🚀
I'd still like to have this covered by a test.

[wasimTQ]

(Although, I'm not able to reproduce the issue #20288 in particular).

@paescuj I think it's because of this issue #20287. I have a working solution of it tho. I'm currently working on that atm.

[wasimTQ]

Can confirm as well 🚀 I'd still like to have this covered by a test.

What should the test cover? Just that the BigInt field is returning in the whereClause and the number is not changed?
I'll work on that. I'm still kinda weak in the testing aspect. So I might need some help there.

[br41nslug]

@paescuj I would love to see tests for this too however there is unfortunately a reason there are no tests for this currently 😬 This specific logic is hidden away in 3 levels deep of nested function which makes testing this separately very difficult if not impossible without refactoring

directus/api/src/utils/apply-query.ts

Line 647 in dc30684

if (['integer', 'float', 'decimal'].includes(type)) {

[paescuj]

@paescuj I think it's because of this issue #20287. I have a working solution of it tho. I'm currently working on that atm.

Nope, I've inserted the value directly into the DB, but apparently it needs to be significantly larger than integer max safe.
That being said, I've noticed #20287 too, so I'm glad to hear you're working on that ❤️

[paescuj]

@paescuj I would love to see tests for this too however there is unfortunately a reason there are no tests for this currently 😬 This specific logic is hidden away in 3 levels deep of nested function which makes testing this separately very difficult if not impossible without refactoring

Hmm, I would have thought it to be feasible by passing in a corresponding schema

directus/api/src/utils/apply-query.test.ts

Line 7 in dc30684

const FAKE_SCHEMA: SchemaOverview = {

and root filter

directus/api/src/utils/apply-query.test.ts

Line 126 in dc30684

describe('applyFilter', () => {

[br41nslug]

In that case I hope im wrong 😄

[wasimTQ]

@paescuj Was the test I wrote good?

[paescuj]

@paescuj Was the test I wrote good?

Yes, thank you! ❤️