Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support international emails in login #21454

Merged
merged 4 commits into from Feb 20, 2024

Conversation

DanielBiegler
Copy link
Contributor

Scope

What's changed:

  • Removed browser form-validation for email on login to support more emails
    • Now users can login with German names for example jürgen@example.com
  • Fixed a type error

Potential Risks / Drawbacks

  • We didnt use form validation for password, nor for the one-time-pass as its simply type="text" with no other constraints - theres no more fields in this form so we should be good.

Review Notes / Questions

  • Didnt remove type="email" so we preserve niceties like custom keyboards on mobile devices
  • Tried adding formnovalidate to the email input but that didnt help, it only worked for me (chromium) with the novalidate on the form directly

Fixes #21309

Copy link

changeset-bot bot commented Feb 16, 2024

🦋 Changeset detected

Latest commit: 908d2b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paescuj paescuj changed the title Fix 21309 support international emails in login Support international emails in login Feb 20, 2024
@paescuj paescuj enabled auto-merge (squash) February 20, 2024 23:52
@paescuj paescuj merged commit d793ce8 into main Feb 20, 2024
4 checks passed
@paescuj paescuj deleted the fix-21309-support-international-emails-in-login branch February 20, 2024 23:55
@github-actions github-actions bot added this to the Next Release milestone Feb 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support for International Email Addresses in Login Form Fails Due to type=email Validation
3 participants