Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Move Migrations out of Extensions #21719

Merged
merged 8 commits into from
Mar 6, 2024
Merged

Conversation

phazonoverload
Copy link
Contributor

Docs for #20626

Copy link

changeset-bot bot commented Mar 6, 2024

🦋 Changeset detected

Latest commit: ba4bd0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! ❤️

Just a small change request:
This newly introduced config option MIGRATIONS_PATH has a default of ./migrations, so there's usually no need to explicitly define the option, migrations can just be placed in this folder.
With the defaults configs, this means the folder is expected to live at the same level as the extensions folder:

├── extensions
└── migrations

@phazonoverload
Copy link
Contributor Author

How's that @paescuj

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's that @paescuj

Perfect 😘👌

@paescuj paescuj enabled auto-merge (squash) March 6, 2024 13:11
@paescuj paescuj merged commit 740b7ca into main Mar 6, 2024
5 checks passed
@paescuj paescuj deleted the docs/migrations-not-extensions branch March 6, 2024 13:14
@github-actions github-actions bot added this to the Next Release milestone Mar 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants