Use Directus version in host field of extensions manifest
#21730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dc6b0bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
h/t to @phazonoverload for reporting this |
Way too many dependencies for just the latest version
fanmingfei
pushed a commit
to fanmingfei/directus
that referenced
this pull request
Mar 7, 2024
…#21730) * Use version from directus package * Use sdk version where appropriate * Add changeset * Don't rely on directus package Way too many dependencies for just the latest version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
hostmanifest field to be the SDK version rather than the Directus versionPotential Risks / Drawbacks
Review Notes / Questions
directuspackage, but that's A) very heavy as that now means the whole of Directus is a dependency, and B) not accurate, as we only really care about the last known breaking change of the extensions system itself 🤔 Having to maintain that constant separately isn't ideal either, but is the best solution I can come up with