Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that v-list-items are displayed correctly throughout the app #21756

Merged
merged 4 commits into from Mar 8, 2024

Conversation

formfcw
Copy link
Contributor

@formfcw formfcw commented Mar 8, 2024

Scope

What's changed:

  • Set fixed height as default (v-list-item)
  • Add a prop that allows to make the height grow (v-list-item)
  • Applied the grow prop to the marketplace extension listing

Before

issue

After

fix

Potential Risks / Drawbacks

  • At least it shouldn't make it worse

Review Notes / Questions

  • I guess you made that change because of the new extension listing in the marketplace, so this is the only place where I have added the grow prop
  • Feel free to rename everything like you wish

Fixes #21755

Copy link

changeset-bot bot commented Mar 8, 2024

🦋 Changeset detected

Latest commit: 6d1338f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @formfcw ❤️

@paescuj paescuj enabled auto-merge (squash) March 8, 2024 11:19
@paescuj paescuj merged commit 87ece96 into directus:main Mar 8, 2024
4 checks passed
@github-actions github-actions bot added this to the Next Release milestone Mar 8, 2024
@formfcw formfcw deleted the fix-v-list-item-height branch March 8, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

v-list-items are not displayed correctly throughout the app
2 participants