Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK relational field type validation fails #21803

Merged
merged 10 commits into from Mar 15, 2024
Merged

SDK relational field type validation fails #21803

merged 10 commits into from Mar 15, 2024

Conversation

br41nslug
Copy link
Member

@br41nslug br41nslug commented Mar 11, 2024

Fixes #21801
Related #19815

Scope

What's changed:

  • Added tests for fields
  • Fixed type issue surfaced by tests

Potential Risks / Drawbacks

  • Not many with adding tests I think

Review Notes / Questions

  • I would like to lorem ipsum

Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: 3d6b077

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@directus/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it fixes the issue 🚀
Added a comment about the new test setup.

sdk/vitest.config.ts Show resolved Hide resolved
sdk/package.json Outdated Show resolved Hide resolved
@paescuj paescuj enabled auto-merge (squash) March 15, 2024 15:18
@paescuj paescuj merged commit 1398692 into main Mar 15, 2024
4 checks passed
@paescuj paescuj deleted the sdk-field-type-tests branch March 15, 2024 15:24
@github-actions github-actions bot added this to the Next Release milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

SDK relational field type validation fails
2 participants