Fix bundle (re-)loading

[hanneskuettner]

Scope

What's changed:

• Instead of skipping over already registered bundle extensions, update the directus_extensions bundle entry records when loading a bundle extension, by removing stale ones and adding new ones
• Instead of using database.insert I'm now using the extensionsItemService.insert, was there any reason it was not used before?

Potential Risks / Drawbacks

• This approach removes bundle extension entries that are no longer present, potentially losing the extension enabled state. In practice this should not matter, however.

Review Notes / Questions

• I would like Pascal to review this since he initially wrote this and might have some thoughts on it.

---

Fixes #21942, fixes #21946, fixes #21922

• Should also fix Bundle extension loading but not working in 10.10.1 #21758, to be checked

[changeset-bot]

🦋 Changeset detected

Latest commit: 70bc671

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@directus/api	Patch
directus	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[hanneskuettner]

Note on the potential fixing of #21758:

Currently this PR only inserts missing module entries and removes DB records of entries that were removed from the bundle (matched based on the bundle ID + folder / entry name). If we want, we can extend the scope of this PR to instead upsert all entries, since we're touching on it anyways.

[paescuj]

As already discussed, I think we can consider #21758 fixed with this PR as the missing bundle entries should be added now.

[br41nslug]

• renaming an endpoint in a bundle (Extensions: Changing name of an entry on a bundle it's not reflected #21942)

• successfully updates the database but doesnt actually load the newly named endpoint either on auto-reload or on a manual restart (endpoint names get compiled into the bundle unlike regular endpoints, so missed a rebuild in that specific test)

• adding a new entry to a bundle (Extensions: Adding a new entry to bundle does not update extensions list #21946, New extensions in bundle aren't reloaded in development mode #21922) (tested with displays, endpoints and hooks)
• removing an entry from a bundle

[hanneskuettner]

successfully updates the database but doesnt actually load the newly named endpoint either on auto-reload or on a manual restart

Interesting find. I'll have a look

[paescuj]

Great work 🎉