Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Save As Copy" to include existing values of relational items #22028

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

paescuj
Copy link
Member

@paescuj paescuj commented Mar 31, 2024

Scope

Fix "Save As Copy" to include existing values of relational items, by only copying fields from updated item which have actually been edited.

Reproduction

As described in #14744.

Before

before.mp4

When editing "Nested M2O":

After

after.mp4

When editing "Nested M2O":

Potential Risks / Drawbacks

None

Review Notes / Questions

None


Fixes #14744

Copy link

changeset-bot bot commented Mar 31, 2024

🦋 Changeset detected

Latest commit: 7bba850

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paescuj paescuj requested review from a team, rijkvanzanten and DanielBiegler and removed request for a team March 31, 2024 22:58
@paescuj paescuj marked this pull request as draft April 3, 2024 14:11
@paescuj paescuj force-pushed the fix-duplication-existing-relation-values branch from 99d4b7b to 7bba850 Compare April 7, 2024 16:13
@paescuj paescuj marked this pull request as ready for review April 7, 2024 16:20
Copy link
Member

@licitdev licitdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ 🚀

@paescuj paescuj merged commit bf9b95a into main Apr 10, 2024
4 checks passed
@paescuj paescuj deleted the fix-duplication-existing-relation-values branch April 10, 2024 14:44
@github-actions github-actions bot added this to the Next Release milestone Apr 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Existing values on unedited fields not propagated for item duplication
2 participants