-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TypeScript in SDK #22065
Update TypeScript in SDK #22065
Conversation
馃 Changeset detectedLatest commit: ec9b9db The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Oh fun 馃槄 |
It looks like this breaking change was the cause https://devblogs.microsoft.com/typescript/announcing-typescript-5-4-beta/#breaking-changes#more-aggressive-reduction-of-intersections-between-type-variables-and-primitive-types |
Wow, thanks for the fast fix 馃殌鉂わ笍 Sounds like that's exactly it 馃憤 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked & the fix looks good to me 馃憤
Superseded by #22211 |
Scope
Update TypeScript version to 5.4 for the SDK
Had to hold back the TypeScript update to 5.4 for the SDK (and therefore also in docs) in #22063 because the newer version introduced a compilation error:@br41nslug Would you mind taking a look at this issue? 馃檹 Seems like it cannot be used as a key, maybe we can narrow down, assert or introduce a check for the type 馃Potential Risks / Drawbacks
Potential type issues
Review Notes / Questions
None