Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Consolidate content versioning" #22412

Merged
merged 1 commit into from
May 7, 2024

Conversation

paescuj
Copy link
Member

@paescuj paescuj commented May 7, 2024

Reverts #22227

The PR requires some finishing touches before we can release it, for example

  • need to verify whether it is always correct to stringify the JSON value in the migration, even on DBs that have native JSON support:
    .update({ delta: JSON.stringify(finalVersionDelta) })
  • the save method now requires update permission on directus_versions - e.g. disregard permissions for the update call (need to check whether that is safe) or make it a breaking change, ...
  • the save return value is currently broken (shouldn't be critical for app though, just when using the api)

This comment was marked as off-topic.

@paescuj paescuj requested a review from licitdev May 7, 2024 09:14
@licitdev licitdev merged commit 537d7f1 into main May 7, 2024
4 checks passed
@licitdev licitdev deleted the revert-22227-consolidate-content-versioning branch May 7, 2024 09:25
@github-actions github-actions bot added this to the Next Release milestone May 7, 2024
@br41nslug
Copy link
Member

br41nslug commented May 7, 2024

@paescuj can you elaborate on those 2 potential issues so they can be addressed instead of reverted? (the json things should be fine)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants