Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system-display-template reactivity #22430

Merged
merged 4 commits into from
May 8, 2024

Conversation

hanneskuettner
Copy link
Contributor

Scope

What's changed:

  • Added shallow reactivity to useFieldTree used in system-display-template by adding a watcher target for the top level fields of a collection

Potential Risks / Drawbacks

  • None I could think of, should only matter if the fields of a collection change in the fieldsStore and the only obvious location that might influence that is the collection settings

Review Notes / Questions

None


Fixes #22429

Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: 031559c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paescuj paescuj self-assigned this May 8, 2024
Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🎸✨

@paescuj paescuj enabled auto-merge (squash) May 8, 2024 12:18
@paescuj paescuj merged commit b7bc479 into main May 8, 2024
4 checks passed
@paescuj paescuj deleted the fix-22429-system-display-template-reactivity branch May 8, 2024 12:22
@github-actions github-actions bot added this to the Next Release milestone May 8, 2024
paescuj added a commit that referenced this pull request May 8, 2024
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

system-display-template is not reactive
2 participants