Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running SDK in dev mode #22432

Merged
merged 2 commits into from
May 8, 2024
Merged

Fix running SDK in dev mode #22432

merged 2 commits into from
May 8, 2024

Conversation

br41nslug
Copy link
Member

A tiny tweak fixing the SDK when running in development mode.

When running pnpm dev in the SDK package it currently is not bundling the output resulting in an index.js that looks like this:

export * from "./auth/index.js";
export * from "./client.js";
export * from "./graphql/index.js";
export * from "./realtime/index.js";
export * from "./rest/index.js";
export * from "./schema/index.js";

However none of these subfolders are actually created if you havent run a pnpm build beforehand.
This fix simply always enables bundling so even in dev mode the package gets properly build into a single file.

Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: 7713d75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@directus/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@hanneskuettner hanneskuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@hanneskuettner hanneskuettner enabled auto-merge (squash) May 8, 2024 13:42
@hanneskuettner hanneskuettner merged commit f5b95ca into main May 8, 2024
4 checks passed
@hanneskuettner hanneskuettner deleted the fix-sdk-dev-mode branch May 8, 2024 13:43
@github-actions github-actions bot added this to the Next Release milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants