Pass onUploadProgress function through to the axios request #6007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AxiosRequest config allows for an onUploadProgress function to be passed in. This is useful, if we want to give users some kind of feedback about the progress of a potential file transfer. Currently, the sdk is only supporting this via direct access to the transport method.
rijkvanzanten
approved these changes
Jun 3, 2021
I don't think we can write a test for this without setting up a full headless browser testing environment as well 🤔 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AxiosRequest config allows for an onUploadProgress function to be passed in. This is useful, if we want to give users some kind of feedback about the progress of a potential file transfer. Currently, the sdk is only supporting this via direct access to the transport method, hence we are adding this extra param there.
I actually looked into writing a test for this in the existing framework. However, from what I understood this is all running in a node environment. As progress events are something that only happens in a browser context, I didn't know of a good way of asserting the function assignment happens as expected.
If someone sees a possibility, I'd be happy to pair up on it or get pointed in the right direction of how to achieve a test for this!